Added Workflow so it tests the code on each push/PR to master #108
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VB10 also when someone opens PR, it would automatically trigger the unit_test.yaml action so that you make sure that everything is fine before reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial issue:
Possible solution:
But this issue may be reproduced again and again.
Better solution: (Learnt from @VB10 that there always should be a thoughtful action)
formatting,analyzeandtest. So I added a workflow which would be triggered on each PR and push tomaster. Thus it would make sure that any code which is not of high quality would not pass the overall test.Additional steps to make tests pass
added sort_pub_dependencies, so it does not show error of sorting dependencies
added void main(){} in
network_manager_test.dartbecause if the test file is empty, the test will automatically fail.